Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #8 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Mario, in FAS you're listed as "Fedora Packager GIT Commit Group (user)" but the FE-NEEDSPONSOR flag set on this ticket means that "it is the first package of a Contributor, the Reviewer must be a Sponsor": https://fedoraproject.org/wiki/Package_Review_Process#Reviewer [...] A very brief look at just the spec file after it has seen a few reviews already: > Source1: http://downloads.sourceforge.net/project/jsoncpp/jsoncpp/0.5.0/jsoncpp-src-0.5.0.tar.gz What's that? Looks like a bundled jsoncpp 0.5.0: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Find a review request for jsoncpp 0.6.0 here: bug 882617 > %doc %{_mandir}/man1/*.1* Hint: %_mandir is marked %doc automatically. > %dir %attr(0755, root, root) %{_sysconfdir}/orthanc > %dir %attr(0755, orthanc, orthanc) %{_sharedstatedir}/orthanc > %dir %attr(0755, orthanc, orthanc) %{_sharedstatedir}/orthanc/db-v3 > %config(noreplace) %attr(0644, root, root) %{_sysconfdir}/orthanc/orthanc.json What happens if you limit usage of %attr to just the two directoris that need an orthanc:orthanc ownership change? Will the other two be incorrect then? I ask that, because preferably %attr is used only for overriding ownership/permissions where the default %install is insufficient. For ordinary files and directories, prefer the %install section as well as fixes to the upstream source. Then %attr would be used only for special situations, i.e. where the default is not enough. * An automated build attempt in Plague/Mock here failed: ... make[2]: python: Command not found make[2]: Leaving directory `/builddir/build/BUILD/Orthanc-0.4.0' Note that you could submit a scratch build in the Fedora Build System: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.29_and_set_up_your_certificate -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fF1AqgST21&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review