Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: ncurses https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226188 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-02-19 21:41 EST ------- About the license, the FSF recommends against using "MIT" because that institution has used many licenses. (The Expat license is also referred to as "MIT", but it's not the same thing.) It's better to use "X11" in that case. The executable documentation is gone now, and the errant dependencies are gone as well. Either way of setting DESTDIR seems fine to me, but you've already changed it to the more conventional method so that's fine. So really I'd say to just set the License: to X11 and this package is done. There's no need to hold things up for that, so I'll ack this now. But it would be good to look into the source of those unused-direct-shlib-dependency warnings at some point. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review