Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230 --- Comment #2 from Gregor Tätzner <gregor@xxxxxxxxxx> --- Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-2.fc17.src.rpm (In reply to comment #1) > I don't understand the > cp -a %{SOURCE0} README.devel > > Why do you want to provide the source tarball as a readme file ? You can't understand that, because it's utter nonsense: I forgot to list the README file in SOURCES and used the first source as README erroneously :) > > Please run the provided test > > BuildRequires: php-cli > > %check > php test.php | grep PASSED > > I don't really agree on the need of a devel sub-package. > Simply add the test.php file and c directory to the %doc of the main package. > (not a blocker, packager choice) agreed, there are just a few files anyway. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bcSojDOld6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review