[Bug 886230] Review Request: php-phpass - Portable password hashing framework for use in PHP applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886230

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx

--- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
I don't understand the 
cp -a %{SOURCE0} README.devel

Why do you want to provide the source tarball as a readme file ?

Please run the provided test

BuildRequires: php-cli

%check
php test.php | grep PASSED

I don't really agree on the need of a devel sub-package.
Simply add the test.php file and c directory to the %doc of the main package.
(not a blocker, packager choice)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gl5u7rIoT7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]