[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866265

--- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> %dir %{_datadir}/%{name}
> %dir %{_datadir}/%{name}/data
> %dir %{_datadir}/%{name}/data/por
> %{_datadir}/%{name}/data/por/ori_por_public.csv

is simple enough. [There are %files sections that are much more difficult to
read with many more %dir statements and many more explicitly listed files.]

Actually, simplifying the above entries further would present a disadvantage,
*if* one wants to ensure that certain files get packaged. For example,

  %{_datadir}/%{name}/

would include *anything*, even an empty directory at %{_datadir}/%{name}.
Imagine you want to make sure that the file
%{_datadir}/%{name}/data/por/ori_por_public.csv gets packaged (or an important
header file that belongs to an API). Well, you could add a corresponding
existance-test to the %check section instead of making the %files section
explicit. But as Denis points out correctly, the build wouldn't fail for files
in the buildroot that were installed by mistake or in a wrong path (without the
packager getting a chance to double-check it). So, there is a use-case for
making %files section more explicit instead of including trees to simplify
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TVObPuEFU8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]