https://bugzilla.redhat.com/show_bug.cgi?id=866265 --- Comment #3 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> --- [For later reference, I just add the corresponding URLs of the packaging guidelines] Spec URL: http://denisarnaud.fedorapeople.org/opentrep/opentrep.spec SRPM URL: http://denisarnaud.fedorapeople.org/opentrep/opentrep-0.5.0-2.fc17.src.rpm (In reply to comment #1) > Better make it "1*" and "3*" for the man pages instead of "1.*". Reference: http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages If you do not mind, I prefer keeping "1.*"/"3.*", as it implies that the manual pages are compressed when installed and that the non compressed version should not be installed. If I specify "1*"/"3*", and that by chance or error, the manual pages are not compressed, I will not be aware of it and the non compressed version will be installed. But I may have missed your point; do not hesitate to elaborate. > defattr is no longer necessary -- also not for EPEL 5. Reference: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions You are right. Done > You simplify > %dir %{_datadir}/%{name} > %dir %{_datadir}/%{name}/data > %dir %{_datadir}/%{name}/data/por > %{_datadir}/%{name}/data/por/ori_por_public.csv > > to > > %{_datadir}/%{name} Reference: http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership http://fedoraproject.org/wiki/Packaging:UnownedDirectories You are right, it can be simplified. However, I did it that way on purpose, in order to install only the data file I intended to be installed. That way, if in the future other data files are added to that directory in the source tar-ball, I will be aware of it. I got my inspiration from: http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Only_Including_Files > You seem to be missing ICU as BR, because the build fails for me. Reference: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires You are right. And I removed soci-mysql-devel, as the MySQL database is no longer used. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review