Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871092 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #23 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Which is unfortunate, because reviewers make mistakes, and that would have been an opportunity to show that you know your stuff. Without adding the needed run-time dependencies to the package, currently the program crashes early with a clear Python traceback. There are no automatic RPM dependencies for Python modules [yet], so you need to add them manually: $ rpm -qpR ./rpmbuild/repodir/fedora-18-build/updf/0.0.2.4-2.fc17/noarch/updf-0.0.2.4-2.fc18.noarch.rpm /usr/bin/python rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ As one can see, just /usr/bin/python is not sufficient for this program, because it contains import statements for several other modules. "pycairo" (for a direct "import cairo" in the source code) and "pygobject3" are just two that are missing, but may be installed already only because other packages depend on them. "numpy" is another crucial one. Also not forget about users, who start with a minimal installation. Those actually file related bug reports from time to time. > Requires: poppler Not a Python package, so the sponsor should have asked you to explain why you added this. > Requires: rubygem-gdk_pixbuf2 Same here. updf is written in Python. Why would it need a Ruby package? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lp0pheCXiz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review