Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871092 --- Comment #22 from Antonio Trande <trpost@xxxxxxxxxxxx> --- Hi Michael. (In reply to comment #21) > Veto! > > That's the brief version of my comment. ;) > > [...] > > The longer version is: This package review has developed into a wrong > direction. Even if there are "two new packager candidates", there are also > "two sponsors", who should try to be more helpful. > > Part of the initial guidance should have been to point at the > ReviewGuidelines page - > https://fedoraproject.org/wiki/Packaging:ReviewGuidelines - and to introduce > the new packagers to "rpmlint", which is the first MUST on that list, and > every packager ought to know it and use it instead of waiting for the > reviewer to do that. Afterall, the packager should have access to the built > rpms already whereas the reviewer would first need to download them or > submit an own build job. > > To the package submitter I recommend being explicit about changes to the > src.rpm/spec and about any tasks that have been completed. For example, > mention whether you've tried to install the package and whether you've been > successful at running the software. The latter is a SHOULD item in the > review guidelines. > > [...] After very useful comment from Christoph, I tried to overcome the language path problem on this package. The only way that I have been able to do is by creating a patch to treat these defects. As you can see, the patch changes all old paths (/usr/share/locale-langpack) to the right ones (/usr/share/locale). Now the package is built fine (I think). > > The following suggestion is absolutely wrong: > > > You can drop the following: > > > > Requires: pycairo > > Requires: poppler > > Requires: rubygem-gdk_pixbuf2 > > As a new packager I would have asked the potential sponsor the "Why?" > question. I trusted blindly :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HfxgHjsQyN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review