Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TMDA - Tagged Message Delivery Agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217654 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-17 08:45 EST ------- Well, (In reply to comment #6) > (In reply to comment #5) > > * Scriptlets > Seems to me, the next best choice is /etc or even /. At least for now, I've > changed it to /. Okay. Almost clean. For -2: * Version/Release specific dependency: - Usually the dependency against main package should be release specific. i.e. ------------------------------------------------------------- Requires: tmda = %{version}-%{release} ------------------------------------------------------------- * Cosmetic issue: consistent macro use - Well, you use both -------------------------------------------------------------- %{_sysconfdir}/rc.d/init.d %{_initrddir} -------------------------------------------------------------- Please unify them. * Again documentation: - Maybe the following documents are useful? -------------------------------------------------------------- NEWS (usually this should be included) -------------------------------------------------------------- * For -emacs package: - Well, I don't think it is useful to split only one file with 27K and to create another package with have no dependency essentially. And.. tmda.el is installed in main package as a documentation. IMO simply unifying .el file into main package and having both %{_datadir}/emacs and %{_datadir}/emacs/site-lisp directories owned also by main package, removing emacs dependency is simpler. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review