Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TMDA - Tagged Message Delivery Agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217654 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-02-17 04:20 EST ------- (In reply to comment #5) > * Scriptlets > - Well, on my environ no one has /etc/ as the home directory. > For the user tofmipd, I think the home directory should be > %{_sysconfdir}/tmda or %{_sysconfdir}/tofmipd with the group > of the directory set as tofmipd. Can we agree that the actual home directory of the daemon does not matter as long as: 1) The directory in not on a mounted filesystem (other than /) 2) It is not a privileged directory (since the program initially runs as root) With that in mind, I really do not want to create an empty directory to just have a home directory for the daemon. In my mind, it doens't really matter outside of that. I wanted /tmp but rpmlint complains for an entirely different reason. Seems to me, the next best choice is /etc or even /. At least for now, I've changed it to /. On my system, the following daemons (users) use / as their home directory: nobody, dbus, avahi, rpc, nscd, haldaemon > ---------------------------------------------- > Requires(post): /sbin/chkconfig > Requires(preun):/sbin/chkconfig > Requires(pre): fedora-usermgmt > Requires(postun):fedora-usermgmt > ---------------------------------------------- > - All these are not needed for main package. These are needed > by -tofmipd package. Fixed that for next release. > - By the way, why do you use the mixed use of > ---------------------------------------------- > /sbin/service tofmipd stop &> /dev/null || : > %{_initrddir}/tofmipd condrestart &> /dev/null || : > ---------------------------------------------- > (i.e. use of /sbin/service v.s. directly calling > scripts under %{_initrddir} ) ? > On Fedora, the use of /sbin/service seems to be recommended, > and Requires(....): /sbin/service is needed. It was my mistake. I had intended to not use service at all as it provides no additional functionality and adds more requirements to the package. Unless you have a strong argument for it, I would rather not use service. > * Documentation > - Check if the document "INSTALL" is needed. It did have a few pointers to documentation, but one of them was wrong, so I choose to not install it. Everything in the file can be found elsewhere. > On FC7 i386, "service tofmipd start" fails 100% as following: > ImportError: No module named mime This was caused by a packaging error which I've fixed. I also added a note to the spec file explaining why the package contains pythonlib Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/tmda.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/tmda-1.1.10-2.fc6.src.rpm * Sat Feb 17 2007 Bernard Johnson <bjohnson@xxxxxxxxxxxx> 1.1.10-2 - consistent start/stop of daemon in scriptlets - move requirements created by scripts to daemon package that requires them - don't include the INSTALL file - it's information can be found elsewhere - %%{python_sitelib}/TMDA/pythonlib/email/mime files were improperly packaged - dependency on initscripts because of use of daemon function - note regarding tmda inclusion of pythonlib/email - change tofmipd user to / home directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review