[Bug 859504] Review Request: php-xcache - Fast, stable PHP opcode cacher

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=859504

--- Comment #7 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
(In reply to comment #6)
> BLOCKER: sources mismatch :(
> 
> It seems that upstream has modified their tarball on november 9, adding some
> files and fixing release number...

Grr... fixed.
https://github.com/remicollet/remirepo/commit/51ffa463f4c25df76928f1ff576b60b1ed6fe04f

> I guess the sed to remove -dev in your specfile is therefore no longer
> needeed.

Yes (at least, it proves that my sanity check is useful)

> Also, it seems that your package should Requires php-common and not php.

fedora-review false positive.
The library doesn't requires php (only php abi).
The web-app requires httpd and mod_php as it provides a httpd config file.

> At last, review script complains about conflicts, but it seems that is ok
> for that package.

Yes (we already have this conflicts in the other opcode caches, eAccelerator
and APC)

Spec URL:
https://raw.github.com/remicollet/remirepo/master/php/php-xcache/php-xcache.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-xcache-3.0.0-1.remi.1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]