Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878612 --- Comment #8 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- Good: * previous comments are fixed Needswork: * running unittests shold be moved to a %check section: %check PYTHONSTARTUP="" nosetests %if 0%{?with_python3} pushd %{py3dir} pushd build/lib PYTHONSTARTUP="" nosetests-%{python3_version} popd popd %endif # with_python3 * Note that I also found that the nosetests for python3 has to be invoked using that macro to determine which version of python3 is on the system. F17 has python3-3.2; F19 and F18 have python3-3.3. * I tried building in koji with the above %check section but there's one failing unittest (on python2). You can see it here: http://kojipkgs.fedoraproject.org//work/tasks/761/4710761/build.log This also fails locally when I try to build it on F17 so it looks like a valid bug. * I reversed the order of the nosetest runs and found a different test failing on python3: http://kojipkgs.fedoraproject.org//work/tasks/877/4710877/build.log Looks like a BuildRequires: ed is needed. Still to check: * rpmlint * Permissions set properly * Package owns all files and directories that it creates and nothing more * All filenames valid utf-8 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review