Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878612 --- Comment #7 from Andrew McNabb <amcnabb@xxxxxxxxxxx> --- (In reply to comment #4) > Review based on the current version: > ab24557ef52c1bc6ff79f81408d9357888dfa55a4d90657576822c24c36f077e > pexpect-u-2.5.1.tar.gz > > Cosmetic: > * Can change python-devel to python2-devel Done. > * No need for -O1 in the build and install lines (brp-python-bytecompile > will (re)do that) Done. > Needswork: > * Change source > http://pypi.python.org/packages/source/p/pexpect-u/pexpect-u-[..] > to Source0: > http://pypi.python.org/packages/source/p/pexpect-u/pexpect-u-[..] > for consistency with other packages and so that spectool -g works (notice > the > correction of missing ":" after source) Done. > * %if (0%{?fedora} > 15 || 0%{?rhel} > 5) => should remove the || 0%{?rhel} > > 5 portion because > rhel6 doesn't have python3 and we've been told that we're not sure what the > story for rhel7 is going to be. Done. > * Tests are shipped with the package. They should be run. This can be done > by > BuildRequiring python-nose (python3-nose for the pythn3 subbpackage) and > running nosetests (nosetests-3.2 for the python3 subpackage) Done. > * Description section in the python3 subpackage should say this is for > python3. > Easiest way is just to tack on a one sentence paragraph that says: > "This package contains the python3 version of this module" Done. > * The comment in the %install section about doing the python3 install first > is > misleading -- there aren't any scripts in %{_bindir} to worry about. > Unless > there is a reason that order matters here my suggestion is simply to remove > the comment. Done. (In reply to comment #6) > So the Obsoletes should be: > > Obsoletes: pexpect <= 2.3-9 Done. The new source RPM is at: http://aml.cs.byu.edu/~amcnabb/python-pexpect-2.5.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review