Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878612 --- Comment #4 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- Review based on the current version: ab24557ef52c1bc6ff79f81408d9357888dfa55a4d90657576822c24c36f077e pexpect-u-2.5.1.tar.gz Good: * Source matches upstream and source url is canonical * Package named according to the naming guidelines * spec file matches package name * License is MIT in the spec file and files distributed in the tarball * LICENSE file included * Spec is legible * No locale files shipped * Not an ELF shared library * Macros used consistently * Contains code, not conent * No large doc * Not a GUI app, no .desktop file Cosmetic: * Can change python-devel to python2-devel * No need for -O1 in the build and install lines (brp-python-bytecompile will (re)do that) Needswork: * Change source http://pypi.python.org/packages/source/p/pexpect-u/pexpect-u-[..] to Source0: http://pypi.python.org/packages/source/p/pexpect-u/pexpect-u-[..] for consistency with other packages and so that spectool -g works (notice the correction of missing ":" after source) * %if (0%{?fedora} > 15 || 0%{?rhel} > 5) => should remove the || 0%{?rhel} > 5 portion because rhel6 doesn't have python3 and we've been told that we're not sure what the story for rhel7 is going to be. * Tests are shipped with the package. They should be run. This can be done by BuildRequiring python-nose (python3-nose for the pythn3 subbpackage) and running nosetests (nosetests-3.2 for the python3 subpackage) * Description section in the python3 subpackage should say this is for python3. Easiest way is just to tack on a one sentence paragraph that says: "This package contains the python3 version of this module" * The comment in the %install section about doing the python3 install first is misleading -- there aren't any scripts in %{_bindir} to worry about. Unless there is a reason that order matters here my suggestion is simply to remove the comment. To Check still: * rpmlint * builds in koji * Permissions set properly * Package owns all files and directories that it creates and nothing more * All filenames valid utf-8 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review