[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

--- Comment #11 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4710481

Requires:       %{name}
is insufficient here. You'll need a fully versioned dependency:
Requires:       %{name}%{?_isa} = %{version}-%{release}

Your package contains a *.desktop file, which needs to be installed separately
or validated:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

Some warnings from rpmlint:

openscad.src:12: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

There are some more, regarding missing manpages and so on. Nothing of interest.

The package versioning could cause some problems when upgrading it once a fully
versioned tarball has been released. Please read the following:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]