Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=869088 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review, Shakthi. (In reply to comment #4) > Issues: > > #01 shared-lib-calls-exit > > Can you please create a patch to remove the exit calls, and send the changes > upstream? Hmmmm. I don't see how to do this without breaking the current API. I will certainly ask upstream to avoid calling exit() inside a library in future versions, but I don't see how to fix this version without breaking its clients. > #02 4ti2 is already available in Fedora. It is not required to package it. > You will need to Require it in the .spec file instead. Oh, sorry, the full story is told in bug 814868 (see comment 1 and the top of the spec file), but I forgot to copy it here. Development of 4ti2 has changed upstreams. The existing 4ti2 package is going to be removed in favor of this one. The previous upstream for 4ti2 released version 1.3.2, then went inactive. One of the 4ti2 developers joined the LattE team, and so this package is now the upstream for 4ti2 (version 1.5 at the moment). Once this package is approved, the current 4ti2 maintainer will take that package through the EOL process. > #03 Please inform upstream to include a LICENSE file in the sources. You can > include the same, and submit it to upstream. My mistake, again. There is a license file (named COPYING), but I neglected to put it into %doc. That has been corrected, along with a couple of other minor packaging errors. New URLs: Spec URL: http://jjames.fedorapeople.org/latte-integrale/latte-integrale.spec SRPM URL: http://jjames.fedorapeople.org/latte-integrale/latte-integrale-1.5.3-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review