Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=869088 Shakthi Kannan <shakthimaan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED --- Comment #4 from Shakthi Kannan <shakthimaan@xxxxxxxxx> --- [+]MUST: rpmlint must be run on every package. The output should be posted in the review. $ rpmlint latte-integrale-1.5.3-1.fc19.src.rpm latte-integrale.src: W: spelling-error %description -l en_US polytopes -> polytheist latte-integrale.src: W: spelling-error %description -l en_US macchiato -> machination latte-integrale.src: W: spelling-error %description -l en_US Köppe -> Kipped latte-integrale.src:33: W: unversioned-explicit-provides bundled(gnulib) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpmlint latte-integrale-1.5.3-1.fc19.x86_64.rpm latte-integrale.x86_64: W: spelling-error %description -l en_US polytopes -> polytheist latte-integrale.x86_64: W: spelling-error %description -l en_US macchiato -> machination latte-integrale.x86_64: W: spelling-error %description -l en_US Köppe -> Kipped latte-integrale.x86_64: W: no-manual-page-for-binary ConvertCDDextToLatte latte-integrale.x86_64: W: no-manual-page-for-binary count latte-integrale.x86_64: W: no-manual-page-for-binary hilbert-from-rays latte-integrale.x86_64: W: no-manual-page-for-binary ehrhart latte-integrale.x86_64: W: no-manual-page-for-binary latte-minimize latte-integrale.x86_64: W: no-manual-page-for-binary latte-maximize latte-integrale.x86_64: W: no-manual-page-for-binary hilbert-from-rays-symm latte-integrale.x86_64: W: no-manual-page-for-binary latte2ext latte-integrale.x86_64: W: no-manual-page-for-binary triangulate latte-integrale.x86_64: W: no-manual-page-for-binary polyhedron-to-cones latte-integrale.x86_64: W: no-manual-page-for-binary latte2ine latte-integrale.x86_64: W: no-manual-page-for-binary integrate latte-integrale.x86_64: W: no-manual-page-for-binary ConvertCDDineToLatte 1 packages and 0 specfiles checked; 0 errors, 16 warnings. $ rpmlint 4ti2-1.5-1.fc19.x86_64.rpm 4ti2.x86_64: W: spelling-error %description -l en_US combinatorial -> combination 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint 4ti2-devel-1.5.3-1.fc19.x86_64.rpm 4ti2-devel.x86_64: W: incoherent-version-dependency-on 4ti2/4ti2-libs/lib4ti2 1.5 1.5.3 4ti2-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint 4ti2-libs-1.5.3-1.fc19.x86_64.rpm 4ti2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/lib4ti2util.so.0.0.0 exit@GLIBC_2.2.5 4ti2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/lib4ti2gmp.so.0.0.0 exit@GLIBC_2.2.5 4ti2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/lib4ti2int32.so.0.0.0 exit@GLIBC_2.2.5 4ti2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libzsolve.so.0.0.0 exit@GLIBC_2.2.5 4ti2-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/lib4ti2int64.so.0.0.0 exit@GLIBC_2.2.5 4ti2-libs.x86_64: W: file-not-utf8 /usr/share/doc/4ti2-libs-1.5.3/NEWS 1 packages and 0 specfiles checked; 0 errors, 6 warnings. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches License - OK No prebuilt external bits - OK Spec legibity - OK Package template - OK Arch support - OK Libexecdir - OK rpmlint - shared-lib-calls-exit needs to be fixed changelogs - OK Source url tag - OK, validated. Build Requires list - OK Summary and description - OK API documentation - OK, in devel package [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. GPL [+]MUST: The License field in the package spec file must match the actual license. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum latte-integrale-1.5.3.tar.gz f7227e5f84ce8fda7d8ba5a1783f929ae9b5d9ce6aff18d59078bde981039bfa [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Successfully built for F18 and F19 http://koji.fedoraproject.org/koji/taskinfo?taskID=4704565 http://koji.fedoraproject.org/koji/taskinfo?taskID=4704562 [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [+]MUST: Packages must NOT bundle copies of system libraries. [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. API documentation in -devel package. [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} [NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [?]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [-]SHOULD: The reviewer should test that the package builds in mock. [+]SHOULD: The reviewer should test that the package functions as described. [-]SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. Issues: #01 shared-lib-calls-exit Can you please create a patch to remove the exit calls, and send the changes upstream? #02 4ti2 is already available in Fedora. It is not required to package it. You will need to Require it in the .spec file instead. #03 Please inform upstream to include a LICENSE file in the sources. You can include the same, and submit it to upstream. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review