[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=875150

--- Comment #8 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> ---
(In reply to comment #7)
> As I understand the "replacement" statement, we can safely use maria instead
> of mysql from the view of application. But I wouldn't rely on any promise to
> use exactly the same file formats in datadir and I'm not sure if there even
> is such promise.

I understand what you mean. You're right. I will move the lib into it's own
dir.

> > The big issue with this is that the libclient files replace the mysql's
> > client files. Also, libs is going to have issues with this.
> 
> If we'll ever replace mysql by maria, I'd suggest to do it together with new
> major/minor version rebase (probably to 5.6). Then soname versions would
> bump and all clients would have to be rebuilt anyway.

Ok, so, I will leave it at that for now. Let's see what comes in the future and
what guidance I can get in the devel list. I will contact upstream as well.

> I'd suggest not to use former mysql's directory silently. Even if it works
> in most cases, it can do bad things if it doesn't work. On the other hand,
> all users would have to do some manual work after installing maria, which is
> annoying. At any case, I think this can be consulted on fedora-list to find
> the least problematic solution.

Ok, so, I will consult. ;)

> > Yeah, I put mysql_clients and client.cnf in the clients subpackage. Why do
> > you mention libs?
> 
> Actually I'm not sure what is meant by mysql_clients. I thought client.cnf
> is a config file for mysql utility and mysql_clients.cnf for libmysqlclient
> libraries. That's why I thought it should be in the same package as that
> library. But maybe I didn't get their purpose correctly.

Honestly, I don't know either. Another thing to consult upstream.

> (In reply to comment #5)
> > errr.. it seems I am having some problems when separating *.so in /var/lib64
> > from everything... It appears that MariaDB needs those libs there...
> 
> I'm not sure if we understand each other here. By separating *.so into devel
> I meant only packaging them into different sub-package, not moving them in
> the tree, just keep them in /usr/lib64.
> 
> You can do the separation as follows:
> 
> %files libs
> %{_libdir}/libmysqlclient*.so.*
> ...
> 
> %files devel
> %{_libdir}/libmysqlclient*.so
> ...

Ok, I think I didn't explain myself correctly. 

I am not moving the file's location. I am packaging *.so in devel, as you asked
and, when devel not installed, this brings problems.

If I put the .so files into devel, you install everything but devel, then, you
get a broken symlink. Look at this dir structure:

$ ls -lS /usr/lib64/libmysql*
-rwxr-xr-x. 1 root root 66511620 oct 19 10:36 /usr/lib64/libmysqld.so.18
-rwxr-xr-x. 1 root root  4937388 oct 19 10:12
/usr/lib64/libmysqlclient.so.18.0.0
-rwxr-xr-x. 1 root root  2222056 oct 19 10:38
/usr/lib64/libmysqlclient_r.so.16.0.0
-rwxr-xr-x. 1 root root  2212424 oct 19 10:38
/usr/lib64/libmysqlclient.so.16.0.0
-rwxr-xr-x. 1 root root  2052744 oct 19 10:38
/usr/lib64/libmysqlclient_r.so.15.0.0
-rwxr-xr-x. 1 root root  2043496 oct 19 10:38
/usr/lib64/libmysqlclient.so.15.0.0
lrwxrwxrwx. 1 root root       26 nov  8 02:03 /usr/lib64/libmysqlclient_r.so.15
-> libmysqlclient_r.so.15.0.0
lrwxrwxrwx. 1 root root       26 nov  8 02:03 /usr/lib64/libmysqlclient_r.so.16
-> libmysqlclient_r.so.16.0.0
lrwxrwxrwx. 1 root root       24 nov  8 02:03 /usr/lib64/libmysqlclient.so.15
-> libmysqlclient.so.15.0.0
lrwxrwxrwx. 1 root root       24 nov  8 02:03 /usr/lib64/libmysqlclient.so.16
-> libmysqlclient.so.16.0.0
lrwxrwxrwx. 1 root root       24 nov  8 02:03 /usr/lib64/libmysqlclient.so.18
-> libmysqlclient.so.18.0.0
lrwxrwxrwx. 1 root root       20 nov  8 02:03 /usr/lib64/libmysqlclient.so ->
libmysqlclient.so.18
lrwxrwxrwx. 1 root root       17 nov  8 02:03 /usr/lib64/libmysqlclient_r.so ->
libmysqlclient.so
lrwxrwxrwx. 1 root root       17 nov  8 02:03 /usr/lib64/libmysqlclient_r.so.18
-> libmysqlclient.so
lrwxrwxrwx. 1 root root       17 nov  8 02:03
/usr/lib64/libmysqlclient_r.so.18.0.0 -> libmysqlclient.so
lrwxrwxrwx. 1 root root       15 nov  8 02:03 /usr/lib64/libmysqld.so ->
libmysqld.so.18


As you can see, some symlinks point to lbmysqlclient.so; including:
libmysqlclient_r.so.18, libmysqlclient_r.so.18.0.0.

That said, you will notice that libmysqlclient.so is a symlink as well that
points to libmysqlclient.so.18 so... should I still put it, and all that points
to it, into devel?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]