[Bug 868940] Review Request: s3ql - Full-Featured File System for Online Data Storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=868940

--- Comment #6 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
$ rpmlint -i -v *
s3ql.src: I: checking
s3ql.src: W: spelling-error %description -l en_US de -> DE, ed, d
The value of this tag appears to be misspelled. Please double-check.

s3ql.src: W: spelling-error %description -l en_US snapshotting -> snaps
hotting, snaps-hotting, snapshot ting
The value of this tag appears to be misspelled. Please double-check.

s3ql.src: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds)
s3ql.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

s3ql.src: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2
(timeout 10 seconds)
s3ql.src: W: invalid-url Source0:
http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

s3ql.i686: I: checking
s3ql.i686: W: spelling-error %description -l en_US de -> DE, ed, d
The value of this tag appears to be misspelled. Please double-check.

s3ql.i686: W: spelling-error %description -l en_US snapshotting -> snaps
hotting, snaps-hotting, snapshot ting
The value of this tag appears to be misspelled. Please double-check.

s3ql.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds)
s3ql.i686: W: private-shared-object-provides
/usr/lib/python2.7/site-packages/s3ql/_deltadump.so _deltadump.so
A shared object soname provides is provided by a file in a path from which
other packages should not directly load shared objects from.  Such shared
objects should thus not be depended on and they should not result in provides
in the containing package.  Get rid of the provides if appropriate, for
example by filtering it out during build.  Note that in some cases this may
require disabling rpmbuild's internal dependency generator.

s3ql.i686: W: no-manual-page-for-binary s3ql_backup
Each executable in standard binary directories should have a man page.

s3ql.i686: W: no-manual-page-for-binary s3ql-fsck_db
Each executable in standard binary directories should have a man page.

s3ql.i686: W: no-manual-page-for-binary s3ql-expire_backups
Each executable in standard binary directories should have a man page.

s3ql.i686: W: no-manual-page-for-binary s3ql-benchmark
Each executable in standard binary directories should have a man page.

s3ql.i686: W: no-manual-page-for-binary s3ql-pcp
Each executable in standard binary directories should have a man page.

s3ql.x86_64: I: checking
s3ql.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d
The value of this tag appears to be misspelled. Please double-check.

s3ql.x86_64: W: spelling-error %description -l en_US snapshotting -> snaps
hotting, snaps-hotting, snapshot ting
The value of this tag appears to be misspelled. Please double-check.

s3ql.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10
seconds)
s3ql.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/s3ql/_deltadump.so _deltadump.so()(64bit)
A shared object soname provides is provided by a file in a path from which
other packages should not directly load shared objects from.  Such shared
objects should thus not be depended on and they should not result in provides
in the containing package.  Get rid of the provides if appropriate, for
example by filtering it out during build.  Note that in some cases this may
require disabling rpmbuild's internal dependency generator.

s3ql.x86_64: W: no-manual-page-for-binary s3ql_backup
Each executable in standard binary directories should have a man page.

s3ql.x86_64: W: no-manual-page-for-binary s3ql-fsck_db
Each executable in standard binary directories should have a man page.

s3ql.x86_64: W: no-manual-page-for-binary s3ql-expire_backups
Each executable in standard binary directories should have a man page.

s3ql.x86_64: W: no-manual-page-for-binary s3ql-benchmark
Each executable in standard binary directories should have a man page.

s3ql.x86_64: W: no-manual-page-for-binary s3ql-pcp
Each executable in standard binary directories should have a man page.

s3ql-debuginfo.i686: I: checking
s3ql-debuginfo.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10
seconds)
s3ql-debuginfo.x86_64: I: checking
s3ql-debuginfo.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout
10 seconds)
s3ql.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

s3ql.spec: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2
(timeout 10 seconds)
s3ql.spec: W: invalid-url Source0:
http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

5 packages and 1 specfiles checked; 0 errors, 22 warnings.


As known from python-apsw and python-llfuse: Please filter out the mentioned
private libraries.

Don't mix spaces and tabs. I recommend to use spaces, because the spec file
looks the same in all editors, independent from the configured tab width.

The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):

rm -rf src/%{name}.egg-info

See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.

Regarding the explicit runtime requirements, the following rule of thumb should
be useful: If package foo-devel is in BuildRequires, then adding foo to
Requires is not needed. Try to remove all the runtime deps and build your
package again. All what's not picked up automatically, add again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]