https://bugzilla.redhat.com/show_bug.cgi?id=871092 --- Comment #11 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> --- (In reply to comment #5) > Done. Whenever you change something, please bump the release and add a changelog entry. We should be at 0.0.2.4-2 now. (In reply to comment #6) > 1) On the Packaging:Guidelines wiki I read: > > >... desktop-file-install MUST be used if the package does not install the file > > or there are changes desired to the .desktop file > > so maybe I must also add 'desktop-file-install' apart from > 'desktop-file-check'. No, one is enough, either desktop-file-install or desktop-file-check > 2) I don't know if the %post %postun scriptlet are necessary in this case. What should they be needed for? And this is not about the %files section either. Mario already pointed out one of the problems with the %files section: You are hardcoding the languages. Whenever a new translation is added, the build will fail. %find_lang does not work because the locales are in /usr/share/locale-langpack. This is wrong. Can you try patching the package to use /usr/share/locale instead? Hint: I had a similar problem and solved it with sed, see line 45-50 at http://pkgs.fedoraproject.org/cgit/rednotebook.git/tree/rednotebook.spec?id=de7097c1#n45 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review