[Bug 871511] Review Request: heimdall - Flash firmware on to Samsung Galaxy S devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=871511

--- Comment #3 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> ---
(In reply to comment #2)
> 1. If at all (running autogen.sh while building is a bad idea), then
> autogen.sh should be run in "%prep" (and not in %build)

I have dropped the use of autogen.sh, now I use the provided configure scripts

> 2. The tarball contains */autom4te.cache, which are not supposed to be
> shipped as part of a tarball.
> Either fix your tarball creation script or remove them in %prep.

Removed

> 3. Running autogen.sh in libpit raises this error:
> ...

No more autogen

> 4. I am observing many "non-virtual destructor might cause undefined
> behaviour" warnings. These should be considered serious.

I cannot do very much here, upstream is making big changes for the next
release, I'll test some development builds to see if this problem persists and
make some bug report.

The updated files are here:
Spec URL: http://jorti.fedorapeople.org/heimdall/heimdall.spec
SRPM URL: http://jorti.fedorapeople.org/heimdall/heimdall-1.3.2-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]