[Bug 871511] Review Request: heimdall - Flash firmware on to Samsung Galaxy S devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=871511

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
This package has quite some amount of issues:

1. If at all (running autogen.sh while building is a bad idea), then autogen.sh
should be run in "%prep" (and not in %build)

2. The tarball contains */autom4te.cache, which are not supposed to be shipped
as part of a tarball.
Either fix your tarball creation script or remove them in %prep.

3. Running autogen.sh in libpit raises this error:
...
+ ./autogen.sh
...
/usr/share/automake-1.12/am/library.am: archiver requires 'AM_PROG_AR' in
'configure.ac'

Please fix it.

4. I am observing many "non-virtual destructor might cause undefined behaviour"
warnings. These should be considered serious.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]