https://bugzilla.redhat.com/show_bug.cgi?id=850641 --- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- === KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items I strongly recommand you include the perl default filter in your spec file. https://fedoraproject.org/wiki/Perl_default_filter [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4612607 [!] Rpmlint output: perl-AI-Categorizer.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/AI/Categorizer/Learner/KNN.pm perl-AI-Categorizer.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/AI/Categorizer/Learner/Guesser.pm 2 packages and 1 specfiles checked; 2 errors, 0 warnings. Perl modules do not need their executable bits set. Please fix this. [x] Package is not relocatable. [x] Buildroot is correct None specified, default used. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. a35d5af19ae0d9ddd0a800b7172a0750 AI-Categorizer-0.09.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [!] Permissions on files are set properly. See above [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawhide-x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4612607 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=14, Tests=242, 1 wallclock secs ( 0.09 usr 0.02 sys + 0.77 cusr 0.10 csys = 0.98 CPU) Result: PASS Note that some of the versionned dependencies dont make sense (how long has it been since we had perl < 5.6.0 in our repos ?) but I won't block on this. Fix the rights on some of these files and you're good to go. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review