[Bug 828188] Review Request: reprepro - Debian package repository producer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=828188

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #10 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
3 remarks:

1. Any particular reasons why you are building without bz2-support?

>From your build.log:
...
checking for BZ2_bzCompressInit in -lbz2... no
configure: WARNING: "no libbz2 found, compiling without"
...

If not, you likely are missing a BuildRequires: bzip2-devel

2. Your spec contains this:
make %{?_smp_mflags} RPM_OPT_FLAGS="$RPM_OPT_FLAGS"

The "RPM_OPT_FLAGS="$RPM_OPT_FLAGS" is meaningless (and therefore bogus).
Please remove it.

3. The code bundles copies of md5.*, sha1.*, sha256.*.

Very "interesting" about these bundled versions is this pretty serious warning
compilation of sha256.c raises:

sha256.c: In function 'SHA256Final':
sha256.c:192:3: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
sha256.c:193:3: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]