https://bugzilla.redhat.com/show_bug.cgi?id=867959 Veeti Paananen <veeti.paananen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veeti.paananen@xxxxxxxxxx --- Comment #2 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> --- Hi, Thanks for the comments. Here's a revised spec: Spec: http://veetipaananen.fi/files/libgit2-2/libgit2.spec SRPM: http://veetipaananen.fi/files/libgit2-2/libgit2-0.17.0-2.fc17.src.rpm Changelog: * Fri Oct 19 2012 Veeti Paananen <veeti.paananen@xxxxxxxxxx> - 0.17.0-2 - Use make for building and installation - Specify minimum CMake version - Remove useless OpenSSL build dependency - Move development documentation to the -devel package - Add code examples to the -devel package Just false spelling errors in rpmlint. --- > * you should set minimal version supported of BR when known (ie: CMake >= 2.6) Done > * use make instead of cmake wrappers as recommended by CMake guidelines. Done > * you don't need to specify CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE (default is debug and it will be stripped afterwards). Removed prefix since make and make install apparently works after all. Their CMakeLists forces -O0 if the build type is debug, so CMAKE_BUILD_TYPE is needed. > You should request that upstream replaces INSTALL_INC by INCLUDE_INSTALL_DIR I'll submit some patches to them to fix the path variables (and possibly the debug thing) later. They might not apply cleanly to 0.17.0 and the spec since their development branch is quite far ahead, though, so I think keeping INSTALL_LIB and INSTALL_INC for now is reasonable. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review