https://bugzilla.redhat.com/show_bug.cgi?id=867959 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx --- Comment #1 from Haïkel Guémar <karlthered@xxxxxxxxx> --- * you should set minimal version supported of BR when known (ie: CMake >= 2.6) * use make instead of cmake wrappers as recommended by CMake guidelines. In the case of build, it allows to enable/disable quickly parallel builds * you don't need to specify CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE (default is debug and it will be stripped afterwards). As for INSTALL_LIB, it has been replaced by the more usual INCLUDE_INSTALL_DIR in master. https://github.com/libgit2/libgit2/pull/823 You should request that upstream replaces INSTALL_INC by INCLUDE_INSTALL_DIR Note, that %cmake macro sets INCLUDE_INSTALL_DIR and LIB_INSTALL_DIR which are the standard de facto in CMake community. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review