https://bugzilla.redhat.com/show_bug.cgi?id=833226 --- Comment #3 from Jos de Kloe <josdekloe@xxxxxxxxx> --- thank you for this updated version. rpmbuild runs fine with the new spec file, and rpmlint has the same result as above. A small comment on the fact that you rename the upstream name pycparser to python-pycparser. According to the guidelines this is not needed for python packages that start their name with 'py'. See: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 This therefore is upto you, both ways are allowed, but removing the rename makes the spec file simpler, which always is a good thing. Also please I would prefer if you would not delete changelog entries, even if the spec file is not yet approved. Finally the LICENSE file should be added to the %doc tag in the %files section. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review