[Bug 833226] Review Request: python-pycparser - C parser and AST generator written in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833226

--- Comment #2 from Scott Tsai <scottt.tw@xxxxxxxxx> ---
(In reply to comment #1)
Spec URL: http://scottt.tw/fedora/python-pycparser/python-pycparser.spec
SRPM URL:
http://scottt.tw/fedora/python-pycparser/python-pycparser-2.08-1.fc17.src.rpm

Changes:
1. Use %{buildroot} instead of $RPM_BUILD_ROOT
-%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT
+%{__python} setup.py install --skip-build --root %{buildroot}

2. List files with more specificity:
 %files
 %doc examples
-# For noarch packages: sitelib
-%{python_sitelib}/*
+%{python_sitelib}/pycparser/
+%{python_sitelib}/pycparser-*.egg-info

3. Remove dos2unix since upstream accepted my line ending patches
-BuildRequires:  dos2unix

 Requires:  python-ply

@@ -26,7 +25,6 @@ need to parse C source code.
 %setup -q -n pycparser-%{version}

 # examples
-find examples -type f -exec dos2unix '{}' ';'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]