https://bugzilla.redhat.com/show_bug.cgi?id=866495 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx Flags| |fedora-review? --- Comment #3 from Michael Scherer <misc@xxxxxxxx> --- Hi, a few remark : - no need for BuildRoot - no need for rm -rf $RPM_BUILD_ROOT in %install ( done by default ) - this is also done by default %defattr(-,root,root) - adding %attr(755,root,root) to all directory is useless, since that's the default setting - this is likely incorrect, 777 is quite dangerous in fact %attr(777, root, root) /etc/vz/conf - why is there such requires : Requires: /sbin/chkconfig - Requires: libxml2 this is likly autodetected - License: GPL this is incorrect, you need to explicit the version of the GPL - the initrd script should be replaced by a systemd file - why does it create a directory in / ? I think this would be blocker since we have tried to reduce cruft there, and not increase it. - %description is quite misleading, this doesn't permit to manage linux container, but openvz container. - I think there is also some grammar/typo fixes to add : This utility allows system administator to control Linux containers, -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review