[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=818629

Josef Stribny <jstribny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jstribny@xxxxxxxxxx

--- Comment #1 from Josef Stribny <jstribny@xxxxxxxxxx> ---
Hi,

1, rpmlint gives me no errors on .spec file and src.rpm:

`0 packages and 1 specfiles checked; 0 errors, 0 warnings.`
`1 packages and 0 specfiles checked; 0 errors, 0 warnings.`

2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already out: 

`gem fetch delayed_job_active_record`
`Fetching: delayed_job_active_record-0.3.3.gem (100%)`

It's recommended to always build for the latest upstream release if available.

3, Running:

`mock -r fedora-rawhide-x86_64
rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception, in
the build.log I found a failing test:
```
+ rspec spec
DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use
`self.primary_key = 'the_name'` instead. (called from <class:Story> at
/builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43)
............................................................F................
Failures:
  1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job
backend worker integration failed jobs should re-schedule jobs after failing
     Failure/Error: @job.attempts.should == 1
       expected: 1
```

This also happens when building using mock for fedora-18-x86_64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]