https://bugzilla.redhat.com/show_bug.cgi?id=863985 --- Comment #8 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #7) > - Since the package uses bundled waf, you need BR's python2-devel Are you sure about that? I mean, if I had a "BuildRequires: waf" instead (to use the Fedora version), that wouldn't drag python-devel in the buildroot: $ repoquery --releasever=18 --requires waf /usr/bin/python python(abi) = 2.7 Both are provided by the python package. So I don't understand why I should add that BR. :-/ > The only issue I see so far is the inclusion of bundled waf, therefore you > should ensure that the upstream be notified of this situation, > and he try out build with the latest version of waf > > So I will leave a note in the formal review that says: > The package does NOT bundle copies of system libraries (except waf, Which is > used only for building) I'm unclear on what you mean here. Do you mean that the package is not approved until I unbundle waf? Or is that a nice to have for the future, but it doesn't block the review? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review