[Bug 863985] Review Request: weighttp - Small tool to benchmark webservers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=863985

--- Comment #7 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Sorry for not being as explicit.
Frankly I was waiting for an update with the comment,  and you were waiting for
me to give more feedback about the spec.
So step to give my comments on the spec.

rpmlint out 
weighttp-0.3-2.fc17.x86_64.rpm
          weighttp-debuginfo-0.3-2.fc17.x86_64.rpm
          weighttp-0.3-2.fc17.src.rpm
weighttp.x86_64: W: spelling-error Summary(en_US) webservers -> web servers,
web-servers, observers
weighttp.x86_64: W: spelling-error %description -l en_US benchmarking -> bench
marking, bench-marking, benchmark
weighttp.x86_64: W: spelling-error %description -l en_US webservers -> web
servers, web-servers, observers
weighttp.x86_64: W: spelling-error %description -l en_US multithreading ->
multitasking
weighttp.x86_64: W: spelling-error %description -l en_US libev -> libel,
believe
weighttp.x86_64: W: spelling-error %description -l en_US epoll -> poll, e poll
weighttp.x86_64: W: spelling-error %description -l en_US kqueue -> queue, k
queue, liqueur

are spelling errors, and can be ignored

weighttp.x86_64: W: no-manual-page-for-binary weighttp
You should contact the upstream for to be add in the near future

weighttp.src: W: invalid-url Source0: weighttp-0.3.tar.xz
You explain clearly in the spec, how to retrieve the source.

- Since the package uses bundled waf, you need BR's python2-devel

The only issue I see so far is the inclusion of bundled waf, therefore you
should ensure that the upstream be notified of this situation, 
and he try out build with the latest version of waf

So I will leave a note in the formal review that says:
The package does NOT bundle copies of system libraries (except waf, Which is
used only for building)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]