https://bugzilla.redhat.com/show_bug.cgi?id=866130 --- Comment #2 from Lorenzo Gil Sanchez <lorenzo.gil.sanchez@xxxxxxxxx> --- Thanks for the review! Here are the updated files: http://lorenzogil.com/rpms/python-hghooks/python-hghooks.spec http://lorenzogil.com/rpms/python-hghooks/python-hghooks-0.5.4-2.fc17.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4592285 I fixed all your points except for the _ast module, which is a python builtin as you can see from these examples: [lgs@xpsm1210 ~]$ python2.6 Python 2.6.8 (unknown, Oct 14 2012, 20:36:05) [GCC 4.7.2 20120921 (Red Hat 4.7.2-2)] on linux3 Type "help", "copyright", "credits" or "license" for more information. >>> import _ast >>> _ast <module '_ast' (built-in)> [lgs@xpsm1210 ~]$ python2.7 Python 2.7.3 (default, Jul 24 2012, 10:05:39) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import _ast >>> _ast <module '_ast' (built-in)> [lgs@xpsm1210 ~]$ python3.2 Python 3.2.3 (default, Jun 8 2012, 05:37:15) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import _ast >>> _ast <module '_ast' (built-in)> I know it's weird that it starts with underscore. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review