[Bug 866130] Review Request: python-hghooks - A set of useful hooks for Mercurial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=866130

Matthias Runge <mrunge@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mrunge@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mrunge@xxxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #1 from Matthias Runge <mrunge@xxxxxxxxxx> ---
I'll do a review.

Lorenzo,

you should be more specific 
%{python_sitelib}/hghooks
%{python_sitelib}/hghooks-%{version}-py?.?.egg-info

instead of:
%{python_sitelib}/*

you should also be specific, if you want python2-devel or python3-devel. 
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

You also could remove that macro at the beginning of your spec:
https://fedoraproject.org/wiki/Packaging:Python#Macros

in file hghooks/code.py:
import _ast
which is not covered by any requirement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]