[Bug 864066] Review Request: libecb - Compiler built-ins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=864066

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4588995

$ rpmlint -i -v *
libecb.noarch: I: checking
libecb.noarch: E: devel-dependency glibc-headers
Your package has a dependency on a devel package but it's not a devel package
itself.

libecb.noarch: W: spelling-error %description -l en_US popcount -> pop count,
pop-count, upcountry
The value of this tag appears to be misspelled. Please double-check.

libecb.noarch: W: spelling-error %description -l en_US prefetch -> pref etch,
pref-etch, prefect
The value of this tag appears to be misspelled. Please double-check.

libecb.noarch: W: spelling-error %description -l en_US noinline -> no inline,
no-inline, nonlinear
The value of this tag appears to be misspelled. Please double-check.

libecb.noarch: I: checking-url http://software.schmorp.de/pkg/libecb (timeout
10 seconds)
libecb.noarch: W: devel-file-in-non-devel-package /usr/include/ecb.h
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

libecb.src: I: checking
libecb.src: W: spelling-error %description -l en_US popcount -> pop count,
pop-count, upcountry
The value of this tag appears to be misspelled. Please double-check.

libecb.src: W: spelling-error %description -l en_US prefetch -> pref etch,
pref-etch, prefect
The value of this tag appears to be misspelled. Please double-check.

libecb.src: W: spelling-error %description -l en_US noinline -> no inline,
no-inline, nonlinear
The value of this tag appears to be misspelled. Please double-check.

libecb.src: I: checking-url http://software.schmorp.de/pkg/libecb (timeout 10
seconds)
libecb.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

libecb.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 2)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

libecb.src: W: invalid-url Source0: libecb-20121008.tar.xz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

libecb.spec: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

libecb.spec:12: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 2)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

libecb.spec: W: invalid-url Source0: libecb-20121008.tar.xz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

2 packages and 1 specfiles checked; 1 errors, 13 warnings.


Some warnings are ignorable. The invalid source is nevertheless valid, because
we have a VCS checkout. It *is* a devel package although it doesn't have the
-devel suffix, because there are no other files.

You just have to fix the missing %build section and the mixed use of spaces and
tabs. I recommend spaces, because this way we get the same view in all text
editors, regardless of the configured tab width.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]