[Bug 849026] Review Request: jam-control - audioserver gui app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=849026

--- Comment #17 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
There are still one issue to be fixed:

(In reply to comment #14)
> warning: File listed twice: /usr/share/jam-control/jackController.py
> warning: File listed twice: /usr/share/jam-control/jackDbusController.py
> warning: File listed twice: /usr/share/jam-control/jam-control.py
> warning: File listed twice: /usr/share/jam-control/main_ui.py
> warning: File listed twice: /usr/share/jam-control/pulseController.py
> warning: File listed twice: /usr/share/jam-control/util.py
> 
> In your %files list, there's the line
> 
> %{_datadir}/%{name}
> 
> which means the folder itself and its contents. This is followed by explicit
> files, which leads to duplicate listings. Either use
> 
> %dir %{_datadir}/%{name}
> 
> or omit the specific files.


Regarding the problem mentioned in comment #15:

#!/bin/python

Such hardcoded paths don't make sense. Better:

#!/usr/bin/env python

or even

#!/usr/bin/env python2 (which is eventually not usable for all distributions)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]