https://bugzilla.redhat.com/show_bug.cgi?id=860505 Marek Goldmann <mgoldman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mgoldman@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Marek Goldmann <mgoldman@xxxxxxxxxx> --- Some issues: 1. Mixing $RPM_BUILD_ROOT and %{buildroot} 2. You can use pom_macros: https://fedoraproject.org/wiki/User:Akurtakov/JavaPackagingDraftUpdate#Patching_Maven_pom.xml_files Example: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-1/opensaml-java.spec 3. Add BR for opensaml-java-parent and drop the patch -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review