[Bug 863569] Review Request: log4c - an application message logging library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=863569

--- Comment #2 from František Dvořák <valtri@xxxxxxxxxx> ---
> 
> Adding manual pages or extra documentation is probably not up to you, that's
> why ignorable. The wrong FSF address should be reported to the upstream
> developers, but no further action is needed from your side.
> 

OK.

> The %defattr line is obsolete, even for EPEL 5. I assume there will be such
> a package, in view of BuildRoot, %clean and so on.
> 

%defattr removed.

> The summary and description for the -devel package are incorrect. There are
> no static files at all, and if this would be the case, they would have to go
> into a -static subpackage anyway. And we have no development documentation
> in the -devel package.
> 

Description corrected.

> What about the log4c-config script in -devel? Shouldn't this go into the
> base package?

No, I think it should be in the -devel. The -config file is used to get
compilation flags for development with log4c and it is better not to install it
without the log4c-devel package.

New URLs:

Spec URL: http://scientific.zcu.cz/fedora/log4c-1.2.2-1b/log4c.spec
SRPM URL:
http://scientific.zcu.cz/fedora/log4c-1.2.2-1b/log4c-1.2.2-1.fc19.src.rpm
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4564782

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]