https://bugzilla.redhat.com/show_bug.cgi?id=839652 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@xxxxxxxxxx --- Comment #3 from Mo Morsi <mmorsi@xxxxxxxxxx> --- Maros some comments: * Please change the summary / description to be in accordance to packaging guidelines http://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description Since there is almost no documentation / comments we can draw upon, we can probably just use something similar to the following for both: "Rubygem extending the ruby string class to include methods that generates colored terminal output" * Why do you exclude %{gem_cache}? * Please move %{gem_instdir}/test/colored_test.rb into the doc subpackage * Since the yardoc dir is only created if rubygem-yard is present you should remove that reference from the specfile all together and rebuild the srpm w/out yard present on your system Thanks -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review