https://bugzilla.redhat.com/show_bug.cgi?id=839650 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@xxxxxxxxxx --- Comment #3 from Mo Morsi <mmorsi@xxxxxxxxxx> --- Maros, there are still some updates needed to this package. As Michal mentioned please move the %{gem_instdir}/spec/ dir into the 'doc' files list. You should not be excluding the Gemfile (the Gemfile.lock is ok), and consider rm'ing the files in one of the previous sections instead of marking them as %exclude (I believe both are acceptable though the former is more common / cleaner). Lastly unless there is a reason not too (if so list it here) please add a %check section where you invoke the spec suite (manually so as not to pull in rake). Thanks. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review