Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034 overholt@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|overholt@xxxxxxxxxx |jjohnstn@xxxxxxxxxx ------- Additional Comments From overholt@xxxxxxxxxx 2007-02-13 14:44 EST ------- Updated SRPM and spec: http://overholt.ca/fedora/asm2-2.1-2jpp.1.src.rpm http://overholt.ca/fedora/asm2.spec (In reply to comment #1) > X - release should be of form Xjpp.Y%{?dist} Fixed. > X - faq.html doesn't match md5sum Removed as it was unnecessary. > X correct buildroot Fixed. > X license text should be included in package and marked with %doc > - currently this is done indirectly via faq.html > - suggest downloading license.html as well and marking as %doc LICENSE.txt (already included) used instead. > X rpmlint on <this package>.srpm gives no output > > W: asm2 non-standard-group Development/Libraries/Java Fixed. > E: asm2 unknown-key GPG#c431416d This was because you didn't have the JPackage key on your system. > W: asm2 mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31) Fixed. > X changelog should use @ instead of "at" I actually don't think this should be changed. > X Vendor tag should not be used Fixed. > X Distribution tag should be removed Done. > X remove %define section free Done. > X remove post and postun sections Done. > X remove ghost Done. > X change javadoc files section to be > - %doc %{_javadocdir}/* Done. > W: asm2 non-standard-group Development/Libraries/Java Fixed. > W: asm2 incoherent-version-in-changelog 0:2.1-1jpp 0:2.1-2jpp It seems to have gone away for me. > W: asm2 wrong-file-end-of-line-encoding /usr/share/doc/asm2-2.1/README.txt Fixed. > W: asm2 class-path-in-manifest /usr/share/java/asm2/asm2-xml-2.1.jar This I don't know how to fix. > [jjohnstn@vermillion noarch]$ rpmlint asm2-javadoc-2.1-2jpp.noarch.rpm > W: asm2-javadoc non-standard-group Development/Documentation > W: asm2-javadoc dangerous-command-in-%post rm > W: asm2-javadoc dangerous-command-in-%postun rm Fixed, fixed, fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review