Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034 jjohnstn@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jjohnstn@xxxxxxxxxx |overholt@xxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From jjohnstn@xxxxxxxxxx 2007-02-13 13:47 EST ------- MUST: X - release should be of form Xjpp.Y%{?dist} X - faq.html doesn't match md5sum X correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) X license text should be included in package and marked with %doc - currently this is done indirectly via faq.html - suggest downloading license.html as well and marking as %doc X rpmlint on <this package>.srpm gives no output W: asm2 non-standard-group Development/Libraries/Java E: asm2 unknown-key GPG#c431416d W: asm2 mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31) X changelog should use @ instead of "at" X Vendor tag should not be used X Distribution tag should be removed X remove %define section free X remove post and postun sections X remove ghost X change javadoc files section to be - %doc %{_javadocdir}/* X run rpmlint on the binary RPMs [jjohnstn@vermillion noarch]$ rpmlint asm2-2.1-2jpp.noarch.rpm W: asm2 non-standard-group Development/Libraries/Java W: asm2 incoherent-version-in-changelog 0:2.1-1jpp 0:2.1-2jpp W: asm2 wrong-file-end-of-line-encoding /usr/share/doc/asm2-2.1/README.txt W: asm2 class-path-in-manifest /usr/share/java/asm2/asm2-xml-2.1.jar [jjohnstn@vermillion noarch]$ rpmlint asm2-javadoc-2.1-2jpp.noarch.rpm W: asm2-javadoc non-standard-group Development/Documentation W: asm2-javadoc dangerous-command-in-%post rm W: asm2-javadoc dangerous-command-in-%postun rm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review