https://bugzilla.redhat.com/show_bug.cgi?id=849829 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Algorithm-SVM.spec.old 2012-08-21 07:05:00.000000000 +0200 +++ perl-Algorithm-SVM.spec 2012-09-19 04:33:53.000000000 +0200 @@ -1,6 +1,6 @@ Name: perl-Algorithm-SVM Version: 0.13 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Perl bindings for the libsvm Support Vector Machine library # Note: The sources bundle a copy of libsvm which is BSD-licensed, @@ -16,14 +16,20 @@ Patch0: Algorithm-SVM-0.13-Unbundle-libsvm.patch Patch1: Algorithm-SVM-0.13-Port-to-libsvm-3.0.patch +BuildRequires: perl(AutoLoader) +BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Test) BuildRequires: libsvm-devel Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +%{?perl_default_filter} + %description Algorithm::SVM implements a Support Vector Machine for Perl. Support Vector -Machines provide a method for creating classifcation functions from a set +Machines provide a method for creating classification functions from a set of labeled training data, from which predictions can be made for subsequent data sets. @@ -45,7 +51,6 @@ find %{buildroot} -type f -name .packlist -exec rm -f {} \; find %{buildroot} -type f -name '*.bs' -size 0 -exec rm -f {} \; -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} %{buildroot}/* @@ -62,5 +67,12 @@ %changelog +* Wed Sep 19 2012 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> - 0.13-2 +- Fix issues based on Petr's review feedback: + - Fix typo 'classifcation' in the package description. + - Filter the private library out of provides. + - Add missing build requirements for the unit tests. + - Stop needlessly removing the empty dirs from the buildroot. + * Tue Aug 21 2012 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> - 0.13-1 - Initial package, with help from cpanspec. > TODO: You can drop removing empty directories from %install section. This is default > behaviour. -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > FIX: Build-require `perl(Carp)' for running tests (lib/Algorithm/SVM/DataSet.pm:5). +BuildRequires: perl(Carp) Ok. > TODO: Build-require `perl(Exporter)' which can dual-live in the future > (lib/Algorithm/SVM.pm:8, http://search.cpan.org/~toddr/Exporter/). +BuildRequires: perl(Exporter) Ok. > TODO: Build-require `perl(AutoLoader)' which can dual-live in the future > (lib/Algorithm/SVM.pm:9, http://search.cpan.org/~smueller/AutoLoader/). +BuildRequires: perl(AutoLoader) Ok. > TODO: Build-require `perl(Test)' which can dual-live in the future (test.pl:8, > http://search.cpan.org/~sburke/Test/). +BuildRequires: perl(Test) Ok. All tests pass. Ok. > TODO: Correct typo `classifcation' in description. > FIX: Do not export private library. Insert `%{?perl_default_filter}' code before > %description section > (https://fedoraproject.org/wiki/Perl/Tips#private-shared-object-provides). $ rpmlint perl-Algorithm-SVM.spec ../SRPMS/perl-Algorithm-SVM-0.13-2.fc19.src.rpm ../RPMS/x86_64/perl-Algorithm-SVM-*-2.* perl-Algorithm-SVM.src: W: spelling-error Summary(en_US) libsvm -> Librium perl-Algorithm-SVM.x86_64: W: spelling-error Summary(en_US) libsvm -> Librium 3 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. > FIX: Do not export private library `SVM.so()'. Insert `%{?perl_default_filter}' code > before %description section > (https://fedoraproject.org/wiki/Perl/Tips#private-shared-object-provides). $ rpm -q --provides -p ../RPMS/x86_64/perl-Algorithm-SVM-0.13-2.fc19.x86_64.rpm | sort | uniq -c 1 perl(Algorithm::SVM) = 0.13 1 perl-Algorithm-SVM = 0.13-2.fc19 1 perl(Algorithm::SVM::DataSet) 1 perl-Algorithm-SVM(x86-64) = 0.13-2.fc19 Binary provides are Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4501792). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review