[Bug 835804] Review Request: perl-Module-Install-ReadmeMarkdownFromPod - Create README.mkdn from POD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=835804

--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Source file is original (verified from
<http://search.cpan.org/CPAN/authors/id/M/MA/MARCEL/Module-Install-ReadmeMarkdownFromPod-0.03.tar.gz>,
SHA-256: f24fdef2feaedda2dbc64582612a0cd76acd471ba6e8e78c08d98eef92969179). Ok.
Source0 and URL are usable Ok.
Summary verified from lib/Module/Install/ReadmeMarkdownFromPod.pm. Ok.
Description verified from lib/Module/Install/ReadmeMarkdownFromPod.pm. Ok.
License verified from lib/Module/Install/ReadmeMarkdownFromPod.pm and README.
Ok.
No XS code, noarch BuildArch is Ok.

TODO: You can remove pruning empty directories from %install section.

TODO: Do not build-require modules bundled in ./inc or remove them from the
directory.

FIX: Specify ./inc dependencies or unbundle the modules (e.g. `perl(Cwd)' at
inc/Module/Install.pm:123:use).

Module::Install::ReadmeFromPod is recommended. Ok.

All tests pass. Ok.

$ rpmlint perl-Module-Install-ReadmeMarkdownFromPod.spec
../SRPMS/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.src.rpm
../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm 
perl-Module-Install-ReadmeMarkdownFromPod.noarch: W: file-not-utf8
/usr/share/doc/perl-Module-Install-ReadmeMarkdownFromPod-0.03/README
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

FIX: Recode README to UTF-8.

$ rpm -q -lv -p
../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Sep 13 12:59
/usr/share/doc/perl-Module-Install-ReadmeMarkdownFromPod-0.03
-rw-r--r--    1 root    root                      501 Oct 20  2009
/usr/share/doc/perl-Module-Install-ReadmeMarkdownFromPod-0.03/Changes
-rw-r--r--    1 root    root                     3670 Oct 20  2009
/usr/share/doc/perl-Module-Install-ReadmeMarkdownFromPod-0.03/README
-rw-r--r--    1 root    root                     3358 Sep 13 12:59
/usr/share/man/man3/Module::Install::ReadmeMarkdownFromPod.3pm.gz
drwxr-xr-x    2 root    root                        0 Sep 13 12:59
/usr/share/perl5/vendor_perl/Module
drwxr-xr-x    2 root    root                        0 Sep 13 12:59
/usr/share/perl5/vendor_perl/Module/Install
-rw-r--r--    1 root    root                     5284 Oct 20  2009
/usr/share/perl5/vendor_perl/Module/Install/ReadmeMarkdownFromPod.pm
File permissions and layout are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm
| sort | uniq -c
      1 perl >= 0:5.006
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.16.1)
      1 perl(Module::Install)
      1 perl(Module::Install::Base)
      1 perl(Module::Install::ReadmeFromPod)
      1 perl(Pod::Markdown)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm
| sort | uniq -c
      1 perl(Module::Install::ReadmeMarkdownFromPod) = 0.03
      1 perl-Module-Install-ReadmeMarkdownFromPod = 0.03-1.fc19
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Module-Install-ReadmeMarkdownFromPod-0.03-1.fc19.noarch.rpm 
Unresolved dependency: perl(Module::Install::ReadmeFromPod)
This is in build root now.
Binary dependencies are Ok.

FIX: Package does not build in F19
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4480373):
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
*** Module::AutoInstall version 1.03
*** Checking for Perl dependencies...
Can't locate CPAN.pm in @INC (@INC contains: inc /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
inc/Module/AutoInstall.pm line 277.


Please correct all `FIX' issues, consider fixing `TODO' items and provide new
spec file.

Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]