[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847420

--- Comment #2 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> ---
(In reply to comment #1)
> TODO: Remove explicit %defattr from %files section.

Will not happen because of Fedora EPEL 5 and 6.

> TODO: Build-require `perl(Time::Local)' because the package can dual-live in
> the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/).
> TODO: Build-require `perl(Exporter)' because the package can dual-live in
> the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/).
> TODO: Build-require `perl(Test)' because the package can dual-live in the
> future (test.pl:8, http://search.cpan.org/~sburke/Test/).

Good pointer, will do so.

> FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation.

Whoops, yes. Will do so.

> TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from `perl
> Makefile.PL' command. It's not necessary.

Without, I recognized a build failure on Fedora EPEL 5 the first time, thus I
re-added it.

I will provide an updated spec file if you are fine with my replies here...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]