https://bugzilla.redhat.com/show_bug.cgi?id=847420 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/M/MS/MSCHMITT/Date-Holidays-DE-1.6.tar.gz>, SHA-256: e1bc9c15123ede6432745afad846557b747bf8c2b587f4b713eb77f4da571968). Ok. Source0 and URL are usable. Ok. Summary verified from DE.pm. Ok. Description verified from README. Ok. License verified from README. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove explicit %defattr from %files section. TODO: Build-require `perl(Time::Local)' because the package can dual-live in the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/). TODO: Build-require `perl(Exporter)' because the package can dual-live in the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/). TODO: Build-require `perl(Test)' because the package can dual-live in the future (test.pl:8, http://search.cpan.org/~sburke/Test/). All tests pass. Ok. $ rpmlint perl-Date-Holidays-DE.spec ../SRPMS/perl-Date-Holidays-DE-1.6-1.fc19.src.rpm ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm perl-Date-Holidays-DE.spec:31: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.spec:40: W: macro-in-comment %doc perl-Date-Holidays-DE.src: W: spelling-error %description -l en_US strftime -> trimmest perl-Date-Holidays-DE.src:31: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.src:40: W: macro-in-comment %doc perl-Date-Holidays-DE.noarch: W: spelling-error %description -l en_US strftime -> trimmest 2 packages and 1 specfiles checked; 0 errors, 6 warnings. FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation. TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from `perl Makefile.PL' command. It's not necessary. $ rpm -q -lv -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 12 14:33 /usr/share/doc/perl-Date-Holidays-DE-1.6 -rw-r--r-- 1 root root 1842 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/Changes -rw-r--r-- 1 root root 1773 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/README drwxr-xr-x 2 root root 0 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/example -rw-r--r-- 1 root root 1862 Aug 15 2010 /usr/share/doc/perl-Date-Holidays-DE-1.6/example/feiertage.pl -rw-r--r-- 1 root root 2102 Aug 27 2009 /usr/share/doc/perl-Date-Holidays-DE-1.6/example/werktage-diff.pl -rw-r--r-- 1 root root 5377 Sep 12 14:33 /usr/share/man/man3/Date::Holidays::DE.3pm.gz drwxr-xr-x 2 root root 0 Sep 12 14:33 /usr/share/perl5/vendor_perl/Date/Holidays -rw-r--r-- 1 root root 17917 Feb 13 2012 /usr/share/perl5/vendor_perl/Date/Holidays/DE.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Date::Calc) >= 5.0 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(POSIX) 1 perl(strict) 1 perl(Time::Local) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Date::Holidays::DE) = 1.6 1 perl-Date-Holidays-DE = 1.6-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4477510). ??? Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review