[Bug 830328] Review Request: gnome-initial-setup - configure your desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830328

--- Comment #7 from Debarshi Ray <debarshi.ray@xxxxxxxxx> ---
- package meets naming guidelines

- package meets packaging guidelines
  use %global instead of %define

- license
  GPLv2+ but in some cases the copyright headers are GPLv3+, but this has been
fixed upstream
  COPYING should be in %doc

- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)

- missing BR: desktop-file-utils, intltool, pkgconfig(iso-codes)

- no unnecessary BR

- locales, but does not use %find_lang

- not relocatable

- does not own all directories,
  %{_datadir}/gnome-initial-setup
  %{_datadir}/gnome-session/sessions
  %{_datadir}/polkit-1/actions

- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop files validate

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]