[Bug 830328] Review Request: gnome-initial-setup - configure your desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830328

--- Comment #6 from Debarshi Ray <debarshi.ray@xxxxxxxxx> ---
[rishi@kolache SPECS]$ rpmlint gnome-initial-setup.spec 
gnome-initial-setup.spec:52: W: macro-in-comment %{buildroot}
gnome-initial-setup.spec:52: W: macro-in-comment %{_sysconfdir}
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

[rishi@kolache SPECS]$ rpmlint ../SRPMS/gnome-initial-setup-0.2-1.fc18.src.rpm 
gnome-initial-setup.src: W: spelling-error %description -l en_US firstboot ->
first boot, first-boot, firstborn
gnome-initial-setup.src:52: W: macro-in-comment %{buildroot}
gnome-initial-setup.src:52: W: macro-in-comment %{_sysconfdir}
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

The pedantic way is to use an extra % with the RPM macros. eg., %{buildroot}
and %{_sysconfdir}.

The spelling mistake is a false alarm.


[rishi@kolache SPECS]$ rpmlint
/home/rishi/devel/rpmbuild/RPMS/x86_64/gnome-initial-setup-0.2-1.fc18.x86_64.rpm 
gnome-initial-setup.x86_64: W: spelling-error %description -l en_US firstboot
-> first boot, first-boot, firstborn

Ditto.


gnome-initial-setup.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/welcome-tour.desktop
gnome-initial-setup.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/gnome-initial-setup-copy-worker.desktop

Can be ignored, I think.


gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/ar/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/as/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/de/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/el/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/es/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/gl/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/he/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/hi/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/id/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/lt/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/lv/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/nb/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/pa/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/pl/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/ru/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/sl/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/sr/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/sr@latin/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/tr/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/uk/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/vi/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/zh_CN/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/zh_HK/LC_MESSAGES/gnome-initial-setup.mo
gnome-initial-setup.x86_64: W: file-not-in-%lang
/usr/share/locale/zh_TW/LC_MESSAGES/gnome-initial-setup.mo
1 packages and 0 specfiles checked; 0 errors, 28 warnings.

Use %find_lang.
See: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files


[rishi@kolache SPECS]$ rpmlint
/home/rishi/devel/rpmbuild/RPMS/x86_64/gnome-initial-setup-debuginfo-0.2-1.fc18.x86_64.rpm
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-clutter.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/cc-common-language.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-private.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-utils.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-photo-dialog.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/cc-common-language.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/cc-timezone-map.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-utils.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/cc-timezone-map.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/gdm-languages.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/gdm-languages.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/pw-utils.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-photo-dialog.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/tz.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-gtk.c
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/tz.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/locarchive.h
gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/pw-utils-pwquality.c
1 packages and 0 specfiles checked; 19 errors, 0 warnings.

These have now been fixed upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]