https://bugzilla.redhat.com/show_bug.cgi?id=852898 --- Comment #5 from Gerd v. Egidy <gerd@xxxxxxxx> --- Hi Ralf, thank you very much for looking into this. > * The directory /usr/include/CImg is unowned and needs to be owned by this > package (MUSTFIX): done > * [SHOULD] CImg.h includes a lot of headers from other packages. Rule of > thumb is to add those packages owning unconditionally included headers, as > "Requires:" to the "*-devel" packages. good idea, done. > From what I can gather, at least libstdc++-devel needs to be BR:'ed, but I > am not sure about the other headers (eg. X11 headers). yeah, libstdc++-devel and glibc-headers are always needed. But from what I could see X11 (and the other stuff) is optional. You need to set defines before they are included. > * [SUGGESTION] The package contains an "examples" subdirectory. AFAIS, this > directory could be utilized as "minimal" compilation test. I therefore would > suggest to build it (e.g. "make linux" or "make mlinux") in %check. done. New package: Spec URL: https://github.com/gvegidy/photivo-rpm/raw/master/CImg/CImg.spec SRPM URL: http://www.egidy.de/fedora/CImg-1.5.1-1.fc17.src.rpm # rpmlint CImg-1.5.1-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # rpmlint CImg-devel-1.5.1-1.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # rpmlint CImg.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Scratch builds ok: http://koji.fedoraproject.org/koji/taskinfo?taskID=4439538 http://koji.fedoraproject.org/koji/taskinfo?taskID=4439563 http://koji.fedoraproject.org/koji/taskinfo?taskID=4439565 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review