https://bugzilla.redhat.com/show_bug.cgi?id=852898 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #4 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Some remarks: * The directory /usr/include/CImg is unowned and needs to be owned by this package (MUSTFIX): # rpm -qlp CImg-devel-1.5.0-4.fc17.noarch.rpm | grep include /usr/include/CImg/CImg.h /usr/include/CImg/plugins /usr/include/CImg/plugins/add_fileformat.h /usr/include/CImg/plugins/cimgIPL.h /usr/include/CImg/plugins/cimg_ipl.h /usr/include/CImg/plugins/cimgmatlab.h /usr/include/CImg/plugins/draw_gradient.h /usr/include/CImg/plugins/jpeg_buffer.h /usr/include/CImg/plugins/loop_macros.h /usr/include/CImg/plugins/nlmeans.h /usr/include/CImg/plugins/skeleton.h /usr/include/CImg/plugins/vrml.h /usr/include/CImg/plugins/vtk.h * [SHOULD] CImg.h includes a lot of headers from other packages. Rule of thumb is to add those packages owning unconditionally included headers, as "Requires:" to the "*-devel" packages. However, due to the "cpp magic" being applied in CImg.h, I am having difficulties in figuring out which of them are mandatory and which are optional ;) >From what I can gather, at least libstdc++-devel needs to be BR:'ed, but I am not sure about the other headers (eg. X11 headers). * [SUGGESTION] The package contains an "examples" subdirectory. AFAIS, this directory could be utilized as "minimal" compilation test. I therefore would suggest to build it (e.g. "make linux" or "make mlinux") in %check. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review